Find the majority element, which appears more than half the time Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Perm-Missing-Elem: 100% functional score, but only 60% performanceDetermining the existence of string IntersectionsFind the dominator in an array of integersJavaScript : Search highest ID in JSON-structure. Increment & return itFind the most frequent element in a sequence without copying elementsReconstruct a string, given a list of subsequence tripletsReturn a sorted ordering of courses such that we can finish all coursesHash table solution to twoSumSum of a sublistFind the elements that appear only once

Is there a kind of relay only consumes power when switching?

When was Kai Tak permanently closed to cargo service?

Wu formula for manifolds with boundary

How would a mousetrap for use in space work?

What does "lightly crushed" mean for cardamon pods?

Do jazz musicians improvise on the parent scale in addition to the chord-scales?

Why do we bend a book to keep it straight?

What is the longest distance a player character can jump in one leap?

Is it fair for a professor to grade us on the possession of past papers?

What does the "x" in "x86" represent?

What's the meaning of "fortified infraction restraint"?

Why wasn't DOSKEY integrated with COMMAND.COM?

How to Make a Beautiful Stacked 3D Plot

Is grep documentation wrong?

Is it cost-effective to upgrade an old-ish Giant Escape R3 commuter bike with entry-level branded parts (wheels, drivetrain)?

What does this Jacques Hadamard quote mean?

How to answer "Have you ever been terminated?"

Should I use a zero-interest credit card for a large one-time purchase?

How could we fake a moon landing now?

If a VARCHAR(MAX) column is included in an index, is the entire value always stored in the index page(s)?

Amount of permutations on an NxNxN Rubik's Cube

Is it ethical to give a final exam after the professor has quit before teaching the remaining chapters of the course?

Do wooden building fires get hotter than 600°C?

Most bit efficient text communication method?



Find the majority element, which appears more than half the time



Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Perm-Missing-Elem: 100% functional score, but only 60% performanceDetermining the existence of string IntersectionsFind the dominator in an array of integersJavaScript : Search highest ID in JSON-structure. Increment & return itFind the most frequent element in a sequence without copying elementsReconstruct a string, given a list of subsequence tripletsReturn a sorted ordering of courses such that we can finish all coursesHash table solution to twoSumSum of a sublistFind the elements that appear only once



.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








10












$begingroup$


The task:




Given a list of elements, find the majority element, which appears
more than half the time (> floor(len(lst) / 2.0)).



You can assume that such element exists.



For example, given [1, 2, 1, 1, 3, 4, 0], return 1.




My solution:



const lst = [1, 2, 1, 1, 3, 4, 0];
const findMajorityElem = lst => lst.reduce((acc, x) => acc.major[1] < acc[x]) acc.major = [x, acc[x]];
return acc;
, major: null).major[0];

console.log(findMajorityElem(lst));









share|improve this question











$endgroup$







  • 5




    $begingroup$
    In the example [1, 2, 1, 1, 3, 4, 0], 1 appears 3 times, floor(len(lst) / 2.0)) is 3, and since 3 is not more than 3, therefore 1 is not the majority element, and the example list doesn't have a majority element.
    $endgroup$
    – janos
    Apr 1 at 16:47











  • $begingroup$
    @janos the example is inaccurate. However it explicitly says I can assume that there exists a majority element
    $endgroup$
    – thadeuszlay
    Apr 1 at 16:54

















10












$begingroup$


The task:




Given a list of elements, find the majority element, which appears
more than half the time (> floor(len(lst) / 2.0)).



You can assume that such element exists.



For example, given [1, 2, 1, 1, 3, 4, 0], return 1.




My solution:



const lst = [1, 2, 1, 1, 3, 4, 0];
const findMajorityElem = lst => lst.reduce((acc, x) => acc.major[1] < acc[x]) acc.major = [x, acc[x]];
return acc;
, major: null).major[0];

console.log(findMajorityElem(lst));









share|improve this question











$endgroup$







  • 5




    $begingroup$
    In the example [1, 2, 1, 1, 3, 4, 0], 1 appears 3 times, floor(len(lst) / 2.0)) is 3, and since 3 is not more than 3, therefore 1 is not the majority element, and the example list doesn't have a majority element.
    $endgroup$
    – janos
    Apr 1 at 16:47











  • $begingroup$
    @janos the example is inaccurate. However it explicitly says I can assume that there exists a majority element
    $endgroup$
    – thadeuszlay
    Apr 1 at 16:54













10












10








10





$begingroup$


The task:




Given a list of elements, find the majority element, which appears
more than half the time (> floor(len(lst) / 2.0)).



You can assume that such element exists.



For example, given [1, 2, 1, 1, 3, 4, 0], return 1.




My solution:



const lst = [1, 2, 1, 1, 3, 4, 0];
const findMajorityElem = lst => lst.reduce((acc, x) => acc.major[1] < acc[x]) acc.major = [x, acc[x]];
return acc;
, major: null).major[0];

console.log(findMajorityElem(lst));









share|improve this question











$endgroup$




The task:




Given a list of elements, find the majority element, which appears
more than half the time (> floor(len(lst) / 2.0)).



You can assume that such element exists.



For example, given [1, 2, 1, 1, 3, 4, 0], return 1.




My solution:



const lst = [1, 2, 1, 1, 3, 4, 0];
const findMajorityElem = lst => lst.reduce((acc, x) => acc.major[1] < acc[x]) acc.major = [x, acc[x]];
return acc;
, major: null).major[0];

console.log(findMajorityElem(lst));






javascript algorithm programming-challenge functional-programming






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Apr 1 at 12:08







thadeuszlay

















asked Apr 1 at 12:00









thadeuszlaythadeuszlay

941616




941616







  • 5




    $begingroup$
    In the example [1, 2, 1, 1, 3, 4, 0], 1 appears 3 times, floor(len(lst) / 2.0)) is 3, and since 3 is not more than 3, therefore 1 is not the majority element, and the example list doesn't have a majority element.
    $endgroup$
    – janos
    Apr 1 at 16:47











  • $begingroup$
    @janos the example is inaccurate. However it explicitly says I can assume that there exists a majority element
    $endgroup$
    – thadeuszlay
    Apr 1 at 16:54












  • 5




    $begingroup$
    In the example [1, 2, 1, 1, 3, 4, 0], 1 appears 3 times, floor(len(lst) / 2.0)) is 3, and since 3 is not more than 3, therefore 1 is not the majority element, and the example list doesn't have a majority element.
    $endgroup$
    – janos
    Apr 1 at 16:47











  • $begingroup$
    @janos the example is inaccurate. However it explicitly says I can assume that there exists a majority element
    $endgroup$
    – thadeuszlay
    Apr 1 at 16:54







5




5




$begingroup$
In the example [1, 2, 1, 1, 3, 4, 0], 1 appears 3 times, floor(len(lst) / 2.0)) is 3, and since 3 is not more than 3, therefore 1 is not the majority element, and the example list doesn't have a majority element.
$endgroup$
– janos
Apr 1 at 16:47





$begingroup$
In the example [1, 2, 1, 1, 3, 4, 0], 1 appears 3 times, floor(len(lst) / 2.0)) is 3, and since 3 is not more than 3, therefore 1 is not the majority element, and the example list doesn't have a majority element.
$endgroup$
– janos
Apr 1 at 16:47













$begingroup$
@janos the example is inaccurate. However it explicitly says I can assume that there exists a majority element
$endgroup$
– thadeuszlay
Apr 1 at 16:54




$begingroup$
@janos the example is inaccurate. However it explicitly says I can assume that there exists a majority element
$endgroup$
– thadeuszlay
Apr 1 at 16:54










3 Answers
3






active

oldest

votes


















14












$begingroup$

If it is known that a majority element exists, then the efficient algorithm to use is the Boyer-Moore majority vote algorithm, which requires only O(1) space.






share|improve this answer









$endgroup$








  • 2




    $begingroup$
    That's a little deceptive... it's $Omega(log n)$ space in terms of bit complexity.
    $endgroup$
    – Charles
    Apr 1 at 20:44






  • 2




    $begingroup$
    @Charles Why would you want to break it down in terms of bits?
    $endgroup$
    – 200_success
    Apr 2 at 1:18






  • 1




    $begingroup$
    I think the question should be, why hide the size of the space requirements? Calling O(1) is, IMO, deceptive: it makes it sound like a fixed amount of space suffices for arbitrarily large arrays, but the larger the array the larger the numbers you need to store, and the larger the numbers the larger the space they take up. Sure, only logarithmically so, but then let's call it logarithmic space, not constant space. It's only constant space in the sense that you use a constant number of words when the words themselves grow logarithmically, but then you're being tricky and hiding the real size.
    $endgroup$
    – Charles
    Apr 2 at 1:59






  • 1




    $begingroup$
    @Charles I don't understand why there's necessarily a correlation between the size of the array and the size of the values within it. To me those are completely orthogonal concerns. It also doesn't seem particularly relevant here anyway, since Javascript's numbers are fixed-size.
    $endgroup$
    – Kyle
    Apr 2 at 2:31






  • 1




    $begingroup$
    @Charles I don’t think that’s entirely fair. Unlike algorithms and structures that meaningfully depend on bit width (radix sort, van Emde Boas trees, ...), this one only has a dependence on it in that it needs to store an array index and an array element (an offline version can also get away with storing two indices instead). That is, it needs as much space as an array access, and you generally want to count this as O(1). Yes, that means you’re counting words, not bits, but that’s the standard cost model, and it makes perfect sense outside of specialized applications.
    $endgroup$
    – Alex Shpilkin
    Apr 2 at 14:17


















3












$begingroup$

@200_success's suggestion seems like the right play here.



That said, I thought it was worth pointing out a couple small improvements to your approach:




  • major need only be the element itself (since you can look up its value in the accumulator)

  • Since you tagged this functional-programming, you can use expressions everywhere, and avoid the if statement.

Revised code:



const findMajorityElem = lst => lst.reduce((acc, x) => , major: null).major


And just for fun, again based on your tag, here's a single-expression solution in Ramda. Again, I don't recommend actually using this given that Boyer-Moore exists:



pipe(
groupBy(identity),
map(length),
toPairs,
converge( reduce(maxBy(last)), [head, identity] ),
head,
parseInt
)(lst)


You can try it here






share|improve this answer









$endgroup$




















    1












    $begingroup$

    If the number exists, it should be done like this and shorter.



    let result =
    [2,3,4,5,1,1,1,2,2,22,2,2,2,2,2,2,2,2,1,1,33,3,2,1,1,1,1,2,2,2,2,2].reduce( (a ,b) =>
    console.log(a)
    return a.length == null ? ( a != b ? [] : a.concat(b)):
    a.length == 0 ? [b] :
    a[a.length-1] == b ? a.concat(b) :
    a.slice(0,a.length-2) ;
    )[0]

    console.log(result) //2





    share|improve this answer











    $endgroup$








    • 1




      $begingroup$
      Welcome to Code Review! and shorter is a bit short on what deserves improvement in the code in the question and why the way proposed is better.
      $endgroup$
      – greybeard
      Apr 2 at 5:42










    • $begingroup$
      Shorter means in Javascript, you may write in a neater way. It’s an implementation of voter algorithm. Just compare the last element in result with a new element, if they are different, just cancel them. Then the final survived element will be the result. Time is o(n) and if in-place space is o(1).
      $endgroup$
      – E.Coms
      Apr 2 at 11:41











    Your Answer






    StackExchange.ifUsing("editor", function ()
    StackExchange.using("externalEditor", function ()
    StackExchange.using("snippets", function ()
    StackExchange.snippets.init();
    );
    );
    , "code-snippets");

    StackExchange.ready(function()
    var channelOptions =
    tags: "".split(" "),
    id: "196"
    ;
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function()
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled)
    StackExchange.using("snippets", function()
    createEditor();
    );

    else
    createEditor();

    );

    function createEditor()
    StackExchange.prepareEditor(
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: false,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: null,
    bindNavPrevention: true,
    postfix: "",
    imageUploader:
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    ,
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    );



    );













    draft saved

    draft discarded


















    StackExchange.ready(
    function ()
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216648%2ffind-the-majority-element-which-appears-more-than-half-the-time%23new-answer', 'question_page');

    );

    Post as a guest















    Required, but never shown

























    3 Answers
    3






    active

    oldest

    votes








    3 Answers
    3






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    14












    $begingroup$

    If it is known that a majority element exists, then the efficient algorithm to use is the Boyer-Moore majority vote algorithm, which requires only O(1) space.






    share|improve this answer









    $endgroup$








    • 2




      $begingroup$
      That's a little deceptive... it's $Omega(log n)$ space in terms of bit complexity.
      $endgroup$
      – Charles
      Apr 1 at 20:44






    • 2




      $begingroup$
      @Charles Why would you want to break it down in terms of bits?
      $endgroup$
      – 200_success
      Apr 2 at 1:18






    • 1




      $begingroup$
      I think the question should be, why hide the size of the space requirements? Calling O(1) is, IMO, deceptive: it makes it sound like a fixed amount of space suffices for arbitrarily large arrays, but the larger the array the larger the numbers you need to store, and the larger the numbers the larger the space they take up. Sure, only logarithmically so, but then let's call it logarithmic space, not constant space. It's only constant space in the sense that you use a constant number of words when the words themselves grow logarithmically, but then you're being tricky and hiding the real size.
      $endgroup$
      – Charles
      Apr 2 at 1:59






    • 1




      $begingroup$
      @Charles I don't understand why there's necessarily a correlation between the size of the array and the size of the values within it. To me those are completely orthogonal concerns. It also doesn't seem particularly relevant here anyway, since Javascript's numbers are fixed-size.
      $endgroup$
      – Kyle
      Apr 2 at 2:31






    • 1




      $begingroup$
      @Charles I don’t think that’s entirely fair. Unlike algorithms and structures that meaningfully depend on bit width (radix sort, van Emde Boas trees, ...), this one only has a dependence on it in that it needs to store an array index and an array element (an offline version can also get away with storing two indices instead). That is, it needs as much space as an array access, and you generally want to count this as O(1). Yes, that means you’re counting words, not bits, but that’s the standard cost model, and it makes perfect sense outside of specialized applications.
      $endgroup$
      – Alex Shpilkin
      Apr 2 at 14:17















    14












    $begingroup$

    If it is known that a majority element exists, then the efficient algorithm to use is the Boyer-Moore majority vote algorithm, which requires only O(1) space.






    share|improve this answer









    $endgroup$








    • 2




      $begingroup$
      That's a little deceptive... it's $Omega(log n)$ space in terms of bit complexity.
      $endgroup$
      – Charles
      Apr 1 at 20:44






    • 2




      $begingroup$
      @Charles Why would you want to break it down in terms of bits?
      $endgroup$
      – 200_success
      Apr 2 at 1:18






    • 1




      $begingroup$
      I think the question should be, why hide the size of the space requirements? Calling O(1) is, IMO, deceptive: it makes it sound like a fixed amount of space suffices for arbitrarily large arrays, but the larger the array the larger the numbers you need to store, and the larger the numbers the larger the space they take up. Sure, only logarithmically so, but then let's call it logarithmic space, not constant space. It's only constant space in the sense that you use a constant number of words when the words themselves grow logarithmically, but then you're being tricky and hiding the real size.
      $endgroup$
      – Charles
      Apr 2 at 1:59






    • 1




      $begingroup$
      @Charles I don't understand why there's necessarily a correlation between the size of the array and the size of the values within it. To me those are completely orthogonal concerns. It also doesn't seem particularly relevant here anyway, since Javascript's numbers are fixed-size.
      $endgroup$
      – Kyle
      Apr 2 at 2:31






    • 1




      $begingroup$
      @Charles I don’t think that’s entirely fair. Unlike algorithms and structures that meaningfully depend on bit width (radix sort, van Emde Boas trees, ...), this one only has a dependence on it in that it needs to store an array index and an array element (an offline version can also get away with storing two indices instead). That is, it needs as much space as an array access, and you generally want to count this as O(1). Yes, that means you’re counting words, not bits, but that’s the standard cost model, and it makes perfect sense outside of specialized applications.
      $endgroup$
      – Alex Shpilkin
      Apr 2 at 14:17













    14












    14








    14





    $begingroup$

    If it is known that a majority element exists, then the efficient algorithm to use is the Boyer-Moore majority vote algorithm, which requires only O(1) space.






    share|improve this answer









    $endgroup$



    If it is known that a majority element exists, then the efficient algorithm to use is the Boyer-Moore majority vote algorithm, which requires only O(1) space.







    share|improve this answer












    share|improve this answer



    share|improve this answer










    answered Apr 1 at 12:38









    200_success200_success

    131k17157422




    131k17157422







    • 2




      $begingroup$
      That's a little deceptive... it's $Omega(log n)$ space in terms of bit complexity.
      $endgroup$
      – Charles
      Apr 1 at 20:44






    • 2




      $begingroup$
      @Charles Why would you want to break it down in terms of bits?
      $endgroup$
      – 200_success
      Apr 2 at 1:18






    • 1




      $begingroup$
      I think the question should be, why hide the size of the space requirements? Calling O(1) is, IMO, deceptive: it makes it sound like a fixed amount of space suffices for arbitrarily large arrays, but the larger the array the larger the numbers you need to store, and the larger the numbers the larger the space they take up. Sure, only logarithmically so, but then let's call it logarithmic space, not constant space. It's only constant space in the sense that you use a constant number of words when the words themselves grow logarithmically, but then you're being tricky and hiding the real size.
      $endgroup$
      – Charles
      Apr 2 at 1:59






    • 1




      $begingroup$
      @Charles I don't understand why there's necessarily a correlation between the size of the array and the size of the values within it. To me those are completely orthogonal concerns. It also doesn't seem particularly relevant here anyway, since Javascript's numbers are fixed-size.
      $endgroup$
      – Kyle
      Apr 2 at 2:31






    • 1




      $begingroup$
      @Charles I don’t think that’s entirely fair. Unlike algorithms and structures that meaningfully depend on bit width (radix sort, van Emde Boas trees, ...), this one only has a dependence on it in that it needs to store an array index and an array element (an offline version can also get away with storing two indices instead). That is, it needs as much space as an array access, and you generally want to count this as O(1). Yes, that means you’re counting words, not bits, but that’s the standard cost model, and it makes perfect sense outside of specialized applications.
      $endgroup$
      – Alex Shpilkin
      Apr 2 at 14:17












    • 2




      $begingroup$
      That's a little deceptive... it's $Omega(log n)$ space in terms of bit complexity.
      $endgroup$
      – Charles
      Apr 1 at 20:44






    • 2




      $begingroup$
      @Charles Why would you want to break it down in terms of bits?
      $endgroup$
      – 200_success
      Apr 2 at 1:18






    • 1




      $begingroup$
      I think the question should be, why hide the size of the space requirements? Calling O(1) is, IMO, deceptive: it makes it sound like a fixed amount of space suffices for arbitrarily large arrays, but the larger the array the larger the numbers you need to store, and the larger the numbers the larger the space they take up. Sure, only logarithmically so, but then let's call it logarithmic space, not constant space. It's only constant space in the sense that you use a constant number of words when the words themselves grow logarithmically, but then you're being tricky and hiding the real size.
      $endgroup$
      – Charles
      Apr 2 at 1:59






    • 1




      $begingroup$
      @Charles I don't understand why there's necessarily a correlation between the size of the array and the size of the values within it. To me those are completely orthogonal concerns. It also doesn't seem particularly relevant here anyway, since Javascript's numbers are fixed-size.
      $endgroup$
      – Kyle
      Apr 2 at 2:31






    • 1




      $begingroup$
      @Charles I don’t think that’s entirely fair. Unlike algorithms and structures that meaningfully depend on bit width (radix sort, van Emde Boas trees, ...), this one only has a dependence on it in that it needs to store an array index and an array element (an offline version can also get away with storing two indices instead). That is, it needs as much space as an array access, and you generally want to count this as O(1). Yes, that means you’re counting words, not bits, but that’s the standard cost model, and it makes perfect sense outside of specialized applications.
      $endgroup$
      – Alex Shpilkin
      Apr 2 at 14:17







    2




    2




    $begingroup$
    That's a little deceptive... it's $Omega(log n)$ space in terms of bit complexity.
    $endgroup$
    – Charles
    Apr 1 at 20:44




    $begingroup$
    That's a little deceptive... it's $Omega(log n)$ space in terms of bit complexity.
    $endgroup$
    – Charles
    Apr 1 at 20:44




    2




    2




    $begingroup$
    @Charles Why would you want to break it down in terms of bits?
    $endgroup$
    – 200_success
    Apr 2 at 1:18




    $begingroup$
    @Charles Why would you want to break it down in terms of bits?
    $endgroup$
    – 200_success
    Apr 2 at 1:18




    1




    1




    $begingroup$
    I think the question should be, why hide the size of the space requirements? Calling O(1) is, IMO, deceptive: it makes it sound like a fixed amount of space suffices for arbitrarily large arrays, but the larger the array the larger the numbers you need to store, and the larger the numbers the larger the space they take up. Sure, only logarithmically so, but then let's call it logarithmic space, not constant space. It's only constant space in the sense that you use a constant number of words when the words themselves grow logarithmically, but then you're being tricky and hiding the real size.
    $endgroup$
    – Charles
    Apr 2 at 1:59




    $begingroup$
    I think the question should be, why hide the size of the space requirements? Calling O(1) is, IMO, deceptive: it makes it sound like a fixed amount of space suffices for arbitrarily large arrays, but the larger the array the larger the numbers you need to store, and the larger the numbers the larger the space they take up. Sure, only logarithmically so, but then let's call it logarithmic space, not constant space. It's only constant space in the sense that you use a constant number of words when the words themselves grow logarithmically, but then you're being tricky and hiding the real size.
    $endgroup$
    – Charles
    Apr 2 at 1:59




    1




    1




    $begingroup$
    @Charles I don't understand why there's necessarily a correlation between the size of the array and the size of the values within it. To me those are completely orthogonal concerns. It also doesn't seem particularly relevant here anyway, since Javascript's numbers are fixed-size.
    $endgroup$
    – Kyle
    Apr 2 at 2:31




    $begingroup$
    @Charles I don't understand why there's necessarily a correlation between the size of the array and the size of the values within it. To me those are completely orthogonal concerns. It also doesn't seem particularly relevant here anyway, since Javascript's numbers are fixed-size.
    $endgroup$
    – Kyle
    Apr 2 at 2:31




    1




    1




    $begingroup$
    @Charles I don’t think that’s entirely fair. Unlike algorithms and structures that meaningfully depend on bit width (radix sort, van Emde Boas trees, ...), this one only has a dependence on it in that it needs to store an array index and an array element (an offline version can also get away with storing two indices instead). That is, it needs as much space as an array access, and you generally want to count this as O(1). Yes, that means you’re counting words, not bits, but that’s the standard cost model, and it makes perfect sense outside of specialized applications.
    $endgroup$
    – Alex Shpilkin
    Apr 2 at 14:17




    $begingroup$
    @Charles I don’t think that’s entirely fair. Unlike algorithms and structures that meaningfully depend on bit width (radix sort, van Emde Boas trees, ...), this one only has a dependence on it in that it needs to store an array index and an array element (an offline version can also get away with storing two indices instead). That is, it needs as much space as an array access, and you generally want to count this as O(1). Yes, that means you’re counting words, not bits, but that’s the standard cost model, and it makes perfect sense outside of specialized applications.
    $endgroup$
    – Alex Shpilkin
    Apr 2 at 14:17













    3












    $begingroup$

    @200_success's suggestion seems like the right play here.



    That said, I thought it was worth pointing out a couple small improvements to your approach:




    • major need only be the element itself (since you can look up its value in the accumulator)

    • Since you tagged this functional-programming, you can use expressions everywhere, and avoid the if statement.

    Revised code:



    const findMajorityElem = lst => lst.reduce((acc, x) => , major: null).major


    And just for fun, again based on your tag, here's a single-expression solution in Ramda. Again, I don't recommend actually using this given that Boyer-Moore exists:



    pipe(
    groupBy(identity),
    map(length),
    toPairs,
    converge( reduce(maxBy(last)), [head, identity] ),
    head,
    parseInt
    )(lst)


    You can try it here






    share|improve this answer









    $endgroup$

















      3












      $begingroup$

      @200_success's suggestion seems like the right play here.



      That said, I thought it was worth pointing out a couple small improvements to your approach:




      • major need only be the element itself (since you can look up its value in the accumulator)

      • Since you tagged this functional-programming, you can use expressions everywhere, and avoid the if statement.

      Revised code:



      const findMajorityElem = lst => lst.reduce((acc, x) => , major: null).major


      And just for fun, again based on your tag, here's a single-expression solution in Ramda. Again, I don't recommend actually using this given that Boyer-Moore exists:



      pipe(
      groupBy(identity),
      map(length),
      toPairs,
      converge( reduce(maxBy(last)), [head, identity] ),
      head,
      parseInt
      )(lst)


      You can try it here






      share|improve this answer









      $endgroup$















        3












        3








        3





        $begingroup$

        @200_success's suggestion seems like the right play here.



        That said, I thought it was worth pointing out a couple small improvements to your approach:




        • major need only be the element itself (since you can look up its value in the accumulator)

        • Since you tagged this functional-programming, you can use expressions everywhere, and avoid the if statement.

        Revised code:



        const findMajorityElem = lst => lst.reduce((acc, x) => , major: null).major


        And just for fun, again based on your tag, here's a single-expression solution in Ramda. Again, I don't recommend actually using this given that Boyer-Moore exists:



        pipe(
        groupBy(identity),
        map(length),
        toPairs,
        converge( reduce(maxBy(last)), [head, identity] ),
        head,
        parseInt
        )(lst)


        You can try it here






        share|improve this answer









        $endgroup$



        @200_success's suggestion seems like the right play here.



        That said, I thought it was worth pointing out a couple small improvements to your approach:




        • major need only be the element itself (since you can look up its value in the accumulator)

        • Since you tagged this functional-programming, you can use expressions everywhere, and avoid the if statement.

        Revised code:



        const findMajorityElem = lst => lst.reduce((acc, x) => , major: null).major


        And just for fun, again based on your tag, here's a single-expression solution in Ramda. Again, I don't recommend actually using this given that Boyer-Moore exists:



        pipe(
        groupBy(identity),
        map(length),
        toPairs,
        converge( reduce(maxBy(last)), [head, identity] ),
        head,
        parseInt
        )(lst)


        You can try it here







        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Apr 1 at 13:03









        JonahJonah

        3,521718




        3,521718





















            1












            $begingroup$

            If the number exists, it should be done like this and shorter.



            let result =
            [2,3,4,5,1,1,1,2,2,22,2,2,2,2,2,2,2,2,1,1,33,3,2,1,1,1,1,2,2,2,2,2].reduce( (a ,b) =>
            console.log(a)
            return a.length == null ? ( a != b ? [] : a.concat(b)):
            a.length == 0 ? [b] :
            a[a.length-1] == b ? a.concat(b) :
            a.slice(0,a.length-2) ;
            )[0]

            console.log(result) //2





            share|improve this answer











            $endgroup$








            • 1




              $begingroup$
              Welcome to Code Review! and shorter is a bit short on what deserves improvement in the code in the question and why the way proposed is better.
              $endgroup$
              – greybeard
              Apr 2 at 5:42










            • $begingroup$
              Shorter means in Javascript, you may write in a neater way. It’s an implementation of voter algorithm. Just compare the last element in result with a new element, if they are different, just cancel them. Then the final survived element will be the result. Time is o(n) and if in-place space is o(1).
              $endgroup$
              – E.Coms
              Apr 2 at 11:41















            1












            $begingroup$

            If the number exists, it should be done like this and shorter.



            let result =
            [2,3,4,5,1,1,1,2,2,22,2,2,2,2,2,2,2,2,1,1,33,3,2,1,1,1,1,2,2,2,2,2].reduce( (a ,b) =>
            console.log(a)
            return a.length == null ? ( a != b ? [] : a.concat(b)):
            a.length == 0 ? [b] :
            a[a.length-1] == b ? a.concat(b) :
            a.slice(0,a.length-2) ;
            )[0]

            console.log(result) //2





            share|improve this answer











            $endgroup$








            • 1




              $begingroup$
              Welcome to Code Review! and shorter is a bit short on what deserves improvement in the code in the question and why the way proposed is better.
              $endgroup$
              – greybeard
              Apr 2 at 5:42










            • $begingroup$
              Shorter means in Javascript, you may write in a neater way. It’s an implementation of voter algorithm. Just compare the last element in result with a new element, if they are different, just cancel them. Then the final survived element will be the result. Time is o(n) and if in-place space is o(1).
              $endgroup$
              – E.Coms
              Apr 2 at 11:41













            1












            1








            1





            $begingroup$

            If the number exists, it should be done like this and shorter.



            let result =
            [2,3,4,5,1,1,1,2,2,22,2,2,2,2,2,2,2,2,1,1,33,3,2,1,1,1,1,2,2,2,2,2].reduce( (a ,b) =>
            console.log(a)
            return a.length == null ? ( a != b ? [] : a.concat(b)):
            a.length == 0 ? [b] :
            a[a.length-1] == b ? a.concat(b) :
            a.slice(0,a.length-2) ;
            )[0]

            console.log(result) //2





            share|improve this answer











            $endgroup$



            If the number exists, it should be done like this and shorter.



            let result =
            [2,3,4,5,1,1,1,2,2,22,2,2,2,2,2,2,2,2,1,1,33,3,2,1,1,1,1,2,2,2,2,2].reduce( (a ,b) =>
            console.log(a)
            return a.length == null ? ( a != b ? [] : a.concat(b)):
            a.length == 0 ? [b] :
            a[a.length-1] == b ? a.concat(b) :
            a.slice(0,a.length-2) ;
            )[0]

            console.log(result) //2






            share|improve this answer














            share|improve this answer



            share|improve this answer








            edited Apr 2 at 0:37

























            answered Apr 2 at 0:27









            E.ComsE.Coms

            1113




            1113







            • 1




              $begingroup$
              Welcome to Code Review! and shorter is a bit short on what deserves improvement in the code in the question and why the way proposed is better.
              $endgroup$
              – greybeard
              Apr 2 at 5:42










            • $begingroup$
              Shorter means in Javascript, you may write in a neater way. It’s an implementation of voter algorithm. Just compare the last element in result with a new element, if they are different, just cancel them. Then the final survived element will be the result. Time is o(n) and if in-place space is o(1).
              $endgroup$
              – E.Coms
              Apr 2 at 11:41












            • 1




              $begingroup$
              Welcome to Code Review! and shorter is a bit short on what deserves improvement in the code in the question and why the way proposed is better.
              $endgroup$
              – greybeard
              Apr 2 at 5:42










            • $begingroup$
              Shorter means in Javascript, you may write in a neater way. It’s an implementation of voter algorithm. Just compare the last element in result with a new element, if they are different, just cancel them. Then the final survived element will be the result. Time is o(n) and if in-place space is o(1).
              $endgroup$
              – E.Coms
              Apr 2 at 11:41







            1




            1




            $begingroup$
            Welcome to Code Review! and shorter is a bit short on what deserves improvement in the code in the question and why the way proposed is better.
            $endgroup$
            – greybeard
            Apr 2 at 5:42




            $begingroup$
            Welcome to Code Review! and shorter is a bit short on what deserves improvement in the code in the question and why the way proposed is better.
            $endgroup$
            – greybeard
            Apr 2 at 5:42












            $begingroup$
            Shorter means in Javascript, you may write in a neater way. It’s an implementation of voter algorithm. Just compare the last element in result with a new element, if they are different, just cancel them. Then the final survived element will be the result. Time is o(n) and if in-place space is o(1).
            $endgroup$
            – E.Coms
            Apr 2 at 11:41




            $begingroup$
            Shorter means in Javascript, you may write in a neater way. It’s an implementation of voter algorithm. Just compare the last element in result with a new element, if they are different, just cancel them. Then the final survived element will be the result. Time is o(n) and if in-place space is o(1).
            $endgroup$
            – E.Coms
            Apr 2 at 11:41

















            draft saved

            draft discarded
















































            Thanks for contributing an answer to Code Review Stack Exchange!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid


            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.

            Use MathJax to format equations. MathJax reference.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216648%2ffind-the-majority-element-which-appears-more-than-half-the-time%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Boston (Lincolnshire) Stedsbyld | Berne yn Boston | NavigaasjemenuBoston Borough CouncilBoston, Lincolnshire

            Ballerup Komuun Stääden an saarpen | Futnuuten | Luke uk diar | Nawigatsjuunwww.ballerup.dkwww.statistikbanken.dk: Tabelle BEF44 (Folketal pr. 1. januar fordelt på byer)Commonskategorii: Ballerup Komuun55° 44′ N, 12° 22′ O

            Serbia Índice Etimología Historia Geografía Entorno natural División administrativa Política Demografía Economía Cultura Deportes Véase también Notas Referencias Bibliografía Enlaces externos Menú de navegación44°49′00″N 20°28′00″E / 44.816666666667, 20.46666666666744°49′00″N 20°28′00″E / 44.816666666667, 20.466666666667U.S. Department of Commerce (2015)«Informe sobre Desarrollo Humano 2018»Kosovo-Metohija.Neutralna Srbija u NATO okruzenju.The SerbsTheories on the Origin of the Serbs.Serbia.Earls: Webster's Quotations, Facts and Phrases.Egeo y Balcanes.Kalemegdan.Southern Pannonia during the age of the Great Migrations.Culture in Serbia.History.The Serbian Origin of the Montenegrins.Nemanjics' period (1186-1353).Stefan Uros (1355-1371).Serbian medieval history.Habsburg–Ottoman Wars (1525–1718).The Ottoman Empire, 1700-1922.The First Serbian Uprising.Miloš, prince of Serbia.3. Bosnia-Hercegovina and the Congress of Berlin.The Balkan Wars and the Partition of Macedonia.The Falcon and the Eagle: Montenegro and Austria-Hungary, 1908-1914.Typhus fever on the eastern front in World War I.Anniversary of WWI battle marked in Serbia.La derrota austriaca en los Balcanes. Fin del Imperio Austro-Húngaro.Imperio austriaco y Reino de Hungría.Los tiempos modernos: del capitalismo a la globalización, siglos XVII al XXI.The period of Croatia within ex-Yugoslavia.Yugoslavia: Much in a Name.Las dictaduras europeas.Croacia: mito y realidad."Crods ask arms".Prólogo a la invasión.La campaña de los Balcanes.La resistencia en Yugoslavia.Jasenovac Research Institute.Día en memoria de las víctimas del genocidio en la Segunda Guerra Mundial.El infierno estuvo en Jasenovac.Croacia empieza a «desenterrar» a sus muertos de Jasenovac.World fascism: a historical encyclopedia, Volumen 1.Tito. Josip Broz.El nuevo orden y la resistencia.La conquista del poder.Algunos aspectos de la economía yugoslava a mediados de 1962.Albania-Kosovo crisis.De Kosovo a Kosova: una visión demográfica.La crisis de la economía yugoslava y la política de "estabilización".Milosevic: el poder de un absolutista."Serbia under Milošević: politics in the 1990s"Milosevic cavó en Kosovo la tumba de la antigua Yugoslavia.La ONU exculpa a Serbia de genocidio en la guerra de Bosnia.Slobodan Milosevic, el burócrata que supo usar el odio.Es la fuerza contra el sufrimiento de muchos inocentes.Matanza de civiles al bombardear la OTAN un puente mientras pasaba un tren.Las consecuencias negativas de los bombardeos de Yugoslavia se sentirán aún durante largo tiempo.Kostunica advierte que la misión de Europa en Kosovo es ilegal.Las 24 horas más largas en la vida de Slobodan Milosevic.Serbia declara la guerra a la mafia por matar a Djindjic.Tadic presentará "quizás en diciembre" la solicitud de entrada en la UE.Montenegro declara su independencia de Serbia.Serbia se declara estado soberano tras separación de Montenegro.«Accordance with International Law of the Unilateral Declaration of Independence by the Provisional Institutions of Self-Government of Kosovo (Request for Advisory Opinion)»Mladic pasa por el médico antes de la audiencia para extraditarloDatos de Serbia y Kosovo.The Carpathian Mountains.Position, Relief, Climate.Transport.Finding birds in Serbia.U Srbiji do 2010. godine 10% teritorije nacionalni parkovi.Geography.Serbia: Climate.Variability of Climate In Serbia In The Second Half of The 20thc Entury.BASIC CLIMATE CHARACTERISTICS FOR THE TERRITORY OF SERBIA.Fauna y flora: Serbia.Serbia and Montenegro.Información general sobre Serbia.Republic of Serbia Environmental Protection Agency (SEPA).Serbia recycling 15% of waste.Reform process of the Serbian energy sector.20-MW Wind Project Being Developed in Serbia.Las Naciones Unidas. Paz para Kosovo.Aniversario sin fiesta.Population by national or ethnic groups by Census 2002.Article 7. Coat of arms, flag and national anthem.Serbia, flag of.Historia.«Serbia and Montenegro in Pictures»Serbia.Serbia aprueba su nueva Constitución con un apoyo de más del 50%.Serbia. Population.«El nacionalista Nikolic gana las elecciones presidenciales en Serbia»El europeísta Borís Tadic gana la segunda vuelta de las presidenciales serbias.Aleksandar Vucic, de ultranacionalista serbio a fervoroso europeístaKostunica condena la declaración del "falso estado" de Kosovo.Comienza el debate sobre la independencia de Kosovo en el TIJ.La Corte Internacional de Justicia dice que Kosovo no violó el derecho internacional al declarar su independenciaKosovo: Enviado de la ONU advierte tensiones y fragilidad.«Bruselas recomienda negociar la adhesión de Serbia tras el acuerdo sobre Kosovo»Monografía de Serbia.Bez smanjivanja Vojske Srbije.Military statistics Serbia and Montenegro.Šutanovac: Vojni budžet za 2009. godinu 70 milijardi dinara.Serbia-Montenegro shortens obligatory military service to six months.No hay justicia para las víctimas de los bombardeos de la OTAN.Zapatero reitera la negativa de España a reconocer la independencia de Kosovo.Anniversary of the signing of the Stabilisation and Association Agreement.Detenido en Serbia Radovan Karadzic, el criminal de guerra más buscado de Europa."Serbia presentará su candidatura de acceso a la UE antes de fin de año".Serbia solicita la adhesión a la UE.Detenido el exgeneral serbobosnio Ratko Mladic, principal acusado del genocidio en los Balcanes«Lista de todos los Estados Miembros de las Naciones Unidas que son parte o signatarios en los diversos instrumentos de derechos humanos de las Naciones Unidas»versión pdfProtocolo Facultativo de la Convención sobre la Eliminación de todas las Formas de Discriminación contra la MujerConvención contra la tortura y otros tratos o penas crueles, inhumanos o degradantesversión pdfProtocolo Facultativo de la Convención sobre los Derechos de las Personas con DiscapacidadEl ACNUR recibe con beneplácito el envío de tropas de la OTAN a Kosovo y se prepara ante una posible llegada de refugiados a Serbia.Kosovo.- El jefe de la Minuk denuncia que los serbios boicotearon las legislativas por 'presiones'.Bosnia and Herzegovina. Population.Datos básicos de Montenegro, historia y evolución política.Serbia y Montenegro. Indicador: Tasa global de fecundidad (por 1000 habitantes).Serbia y Montenegro. Indicador: Tasa bruta de mortalidad (por 1000 habitantes).Population.Falleció el patriarca de la Iglesia Ortodoxa serbia.Atacan en Kosovo autobuses con peregrinos tras la investidura del patriarca serbio IrinejSerbian in Hungary.Tasas de cambio."Kosovo es de todos sus ciudadanos".Report for Serbia.Country groups by income.GROSS DOMESTIC PRODUCT (GDP) OF THE REPUBLIC OF SERBIA 1997–2007.Economic Trends in the Republic of Serbia 2006.National Accounts Statitics.Саопштења за јавност.GDP per inhabitant varied by one to six across the EU27 Member States.Un pacto de estabilidad para Serbia.Unemployment rate rises in Serbia.Serbia, Belarus agree free trade to woo investors.Serbia, Turkey call investors to Serbia.Success Stories.U.S. Private Investment in Serbia and Montenegro.Positive trend.Banks in Serbia.La Cámara de Comercio acompaña a empresas madrileñas a Serbia y Croacia.Serbia Industries.Energy and mining.Agriculture.Late crops, fruit and grapes output, 2008.Rebranding Serbia: A Hobby Shortly to Become a Full-Time Job.Final data on livestock statistics, 2008.Serbian cell-phone users.U Srbiji sve više računara.Телекомуникације.U Srbiji 27 odsto gradjana koristi Internet.Serbia and Montenegro.Тренд гледаности програма РТС-а у 2008. и 2009.години.Serbian railways.General Terms.El mercado del transporte aéreo en Serbia.Statistics.Vehículos de motor registrados.Planes ambiciosos para el transporte fluvial.Turismo.Turistički promet u Republici Srbiji u periodu januar-novembar 2007. godine.Your Guide to Culture.Novi Sad - city of culture.Nis - european crossroads.Serbia. Properties inscribed on the World Heritage List .Stari Ras and Sopoćani.Studenica Monastery.Medieval Monuments in Kosovo.Gamzigrad-Romuliana, Palace of Galerius.Skiing and snowboarding in Kopaonik.Tara.New7Wonders of Nature Finalists.Pilgrimage of Saint Sava.Exit Festival: Best european festival.Banje u Srbiji.«The Encyclopedia of world history»Culture.Centenario del arte serbio.«Djordje Andrejevic Kun: el único pintor de los brigadistas yugoslavos de la guerra civil española»About the museum.The collections.Miroslav Gospel – Manuscript from 1180.Historicity in the Serbo-Croatian Heroic Epic.Culture and Sport.Conversación con el rector del Seminario San Sava.'Reina Margot' funde drama, historia y gesto con música de Goran Bregovic.Serbia gana Eurovisión y España decepciona de nuevo con un vigésimo puesto.Home.Story.Emir Kusturica.Tercer oro para Paskaljevic.Nikola Tesla Year.Home.Tesla, un genio tomado por loco.Aniversario de la muerte de Nikola Tesla.El Museo Nikola Tesla en Belgrado.El inventor del mundo actual.República de Serbia.University of Belgrade official statistics.University of Novi Sad.University of Kragujevac.University of Nis.Comida. Cocina serbia.Cooking.Montenegro se convertirá en el miembro 204 del movimiento olímpico.España, campeona de Europa de baloncesto.El Partizan de Belgrado se corona campeón por octava vez consecutiva.Serbia se clasifica para el Mundial de 2010 de Sudáfrica.Serbia Name Squad For Northern Ireland And South Korea Tests.Fútbol.- El Partizán de Belgrado se proclama campeón de la Liga serbia.Clasificacion final Mundial de balonmano Croacia 2009.Serbia vence a España y se consagra campeón mundial de waterpolo.Novak Djokovic no convence pero gana en Australia.Gana Ana Ivanovic el Roland Garros.Serena Williams gana el US Open por tercera vez.Biography.Bradt Travel Guide SerbiaThe Encyclopedia of World War IGobierno de SerbiaPortal del Gobierno de SerbiaPresidencia de SerbiaAsamblea Nacional SerbiaMinisterio de Asuntos exteriores de SerbiaBanco Nacional de SerbiaAgencia Serbia para la Promoción de la Inversión y la ExportaciónOficina de Estadísticas de SerbiaCIA. Factbook 2008Organización nacional de turismo de SerbiaDiscover SerbiaConoce SerbiaNoticias de SerbiaSerbiaWorldCat1512028760000 0000 9526 67094054598-2n8519591900570825ge1309191004530741010url17413117006669D055771Serbia